-
Couldn't load subscription status.
- Fork 53
6.3.1 Far-Backwards Lattice #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
|
@nat93 @adamjaro Please could you check the quadrupole fields have been calculated correctly from the tables, I don't think the x/y divergence plots I see quite match those you both previously shared. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonge have the quad fields been confirmed yet? I will approve once your question has been answered by either @adamjaro or @nat93 to make sure things are correct.
Also, you may need to pull the latest version of epic because there are some new magnet XML files I put together. I made some new changes today. You should wait until those are approved, and merged, and THEN pull that new version in, and add your changes to the additional XML files for the magnets.
Hi @simonge,
I used a similar formula to calculate the gradient (K1): K1 = 3.33564 x K1L / length x pc |
|
@nat93 Great, thanks for confirming. @ajentsch This might still be a draft for a bit while as it will break the Low-Q2 ML reconstruction in EICrecon. @veprbl @wdconinc Any idea how the (semi)automatic updating of the neural network is going to work in practice. Ideally it would come as part of this PR but the performance would only get checked checked downstream as a benchmark which I don't believe are ever run on epic PRs. |
|
My thoughts.
Can/should there be human intervention in some of these steps? |
I believe If training is too slow to be ran every time, there is a precedent for benchmarks that only run on demand: |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
### Briefly, what does this PR introduce? Appears to fix #902. Tiny torus segments were being created where the alignment of one tube didn't match the next due to floating point rounding errors. Below a limit of 0.01 mrad difference now is rounded down to 0. Length of `Pipe_to_Q1APR` has also been fixed so it correctly joins with the central beampipe. Most of this may be reworked again after #893 and #838 ### What kind of change does this PR introduce? - [x] Bug fix (issue #902 ) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? ### Does this PR change default behavior? --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <[email protected]>

Briefly, what does this PR introduce?
Originally instigated by moving the B2eR magnet out of the cryostat, this geometry matches the most recent lattice of the accelerator in the far backward region.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Changes the path of electrons in the far-backward region. This will break the Low-Q2 Tagger reconstruction, simple retraining of the network should be sufficient after this is eventually merged.